Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically transcribe when ASR active on receiver #1665

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

matthiasn
Copy link
Owner

This PR adapts the speech recognition such that when on the creator, auto transcribe was disabled and it is enabled on the receiver side, the ASR using Whisper will start automatically. This is in particular a scenario where ASR is disabled on mobile, where it might use too much battery.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (597a2d3) 68.89% compared to head (7d66f5e) 68.88%.

Files Patch % Lines
lib/services/asr_service.dart 0.00% 3 Missing ⚠️
lib/logic/persistence_logic.dart 0.00% 2 Missing ⚠️
lib/blocs/audio/recorder_cubit.dart 0.00% 1 Missing ⚠️
lib/sync/inbox/process_message.dart 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
- Coverage   68.89%   68.88%   -0.01%     
==========================================
  Files         272      272              
  Lines       10749    10752       +3     
==========================================
+ Hits         7405     7407       +2     
- Misses       3344     3345       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthiasn matthiasn merged commit cb4f327 into main Jan 16, 2024
5 checks passed
@matthiasn matthiasn deleted the feat/auto_asr_on_receive branch January 19, 2024 21:50
@matthiasn matthiasn restored the feat/auto_asr_on_receive branch January 19, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant