-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Django v5.0.2 #137
Conversation
e2c7a45
to
db472db
Compare
env_path = load_dotenv(os.path.join(BASE_DIR, '.env')) | ||
load_dotenv(env_path) | ||
|
||
# Quick-start development settings - unsuitable for production | ||
# See https://docs.djangoproject.com/en/4.2/howto/deployment/checklist/ | ||
# See https://docs.djangoproject.com/en/5.0/howto/deployment/checklist/ | ||
|
||
# SECURITY WARNING: keep the secret key used in production secret! | ||
# SECRET_KEY = 'django-insecure-&psk#na5l=p3q8_a+-$4w1f^lt3lx1c@d*p4x$ymm_rn7pwb87' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# SECRET_KEY = 'django-insecure-&psk#na5l=p3q8_a+-$4w1f^lt3lx1c@d*p4x$ymm_rn7pwb87' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but I want to keep this. If you're inspecting this code it is good to be able to see the original code that was commented out, starting from the original django template. I am also grateful for this kind of thing every time I update the tutorial because it reminds me of the next things to do.
Not sure what the usual approach to caching is, but I needed to start a private browsing session after running the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Hamish. A couple of comments for you to take a look, but leaving a +1 - nice 🎉
You're not wrong. I usually clear my cache in development when I switch to the blog. My inclination is to ignore this. We could offer advice, but I suspect very few actually do the blog part and noting that you might have do to this would therefore be a distraction. We've never had a question on it, and the cause/fix when switching are easy to work out. |
Thanks for the review. Much appreciated! |
Sounds good to me! Something to keep note of in case it comes up. Cheers! |
This updates Django from 4 to 5.
Associated docs in mdn/content#32406