Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows/pr-test): resolve files in CONTENT_TRANSLATED_ROOT #25580

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 24, 2025

Description

The new PR Test workflow doesn't build any file, because it looks for the translated-content files inside the content checkout.

Motivation

Ensures that the PR Review Companion continues to work as expected.

Additional details

Related issues and pull requests

See: #25568 (comment)

We were resolving them in $pwd, which was the content root.
@github-actions github-actions bot added l10n-fr Issues related to French content. system Infrastructure and configuration for the project labels Jan 24, 2025
@caugner caugner force-pushed the MP-1851-resolve-files-in-translated-root branch from fe937b3 to 3b0fd8a Compare January 24, 2025 20:02
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Preview URLs

(comment last updated: 2025-01-24 20:12:39)

@caugner caugner marked this pull request as ready for review January 24, 2025 20:13
@caugner caugner requested review from a team as code owners January 24, 2025 20:13
@caugner caugner requested review from cw118 and removed request for a team January 24, 2025 20:13
@github-actions github-actions bot removed the l10n-fr Issues related to French content. label Jan 24, 2025
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as the change is low risk, but important.

@caugner caugner merged commit 9e9c8d0 into main Jan 24, 2025
11 of 12 checks passed
@caugner caugner deleted the MP-1851-resolve-files-in-translated-root branch January 24, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant