Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync page guidelines/live-samples #25864

Merged

Conversation

mariofdezzz
Copy link
Contributor

Description

Synchronize with latest updates to MDN writing guidelines

https://developer.mozilla.org/es/docs/mdn/writing_guidelines/page_structures/live_samples

Related issues and pull requests

Relates to #14993

@mariofdezzz mariofdezzz requested a review from a team as a code owner February 11, 2025 18:39
@mariofdezzz mariofdezzz requested review from davbrito and removed request for a team February 11, 2025 18:39
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Feb 11, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mdn-linter

[mdn-linter] reported by reviewdog 🐶

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Preview URLs

(comment last updated: 2025-02-18 20:33:12)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mariofdezzz
Copy link
Contributor Author

@JuanVqz @Graywolf9 hay alguien revisando esto?

@Graywolf9
Copy link
Contributor

Hola! Una disculpa, sí, yo lo estoy revisano solo fue un poco largo para terminarlo junto con el día laboral, pero hoy queda, gracias por la espera

Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola de nuevo! Muchas gracias por tu tiempo y espera, por fin he terminado la revisión y te dejo algunos comentarios y observaciones

Nuevamente muchas gracias por toda tu ayuda

@mariofdezzz
Copy link
Contributor Author

Buenas @Graywolf9 ! Muchas gracias por tu tiempo, es una pr muy larga y cuesta bastante revisarla.

Que quede claro que no tengo ninguna prisa por el resultado, solo quería confirmar que alguien estaba tomando la revisión. No me gustaría que tomaras un esfuerzo extra, cada uno tenemos nuestras ocupaciones.

Tomo nota de todas las correcciones para futuras contribuciones, lo siento de antemano por tanta corrección que has tenido que realizar. Gracias por tanto esfuerzo ❤️

Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente, ya solo he agregado el sourceCommit de paridad con su versión en inglés.

Muchas gracias por tu tiempo y gran ayuda

@Graywolf9 Graywolf9 merged commit 4523d4e into mdn:main Feb 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants