Skip to content

Commit

Permalink
chore: MR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewlynch committed Jan 3, 2025
1 parent d0f1fc4 commit 2e024f1
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 74 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 22
node-version: 18

- name: Check Yarn Version
run: yarn --version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 22
node-version: 18
registry-url: "https://registry.npmjs.org"

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 22
node-version: 18
registry-url: "https://registry.npmjs.org"

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
],
"version": "0.17.1",
"engines": {
"node": ">=22.0.0"
"node": ">=18.18"
}
}
68 changes: 0 additions & 68 deletions recipes/react-router/app/entry.server.tsx

This file was deleted.

4 changes: 2 additions & 2 deletions recipes/react-router/app/root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export function ErrorBoundary({ error }: Route.ErrorBoundaryProps) {
}

return (
<main className="pt-16 p-4 container mx-auto">
<main>
<h1>{message}</h1>
<p>{details}</p>
{stack && (
<pre className="w-full p-4 overflow-x-auto">
<pre>
<code>{stack}</code>
</pre>
)}
Expand Down
3 changes: 3 additions & 0 deletions recipes/react-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@
"typescript": "^5.7.2",
"vite": "^5.4.11",
"vite-tsconfig-paths": "^5.1.4"
},
"engines": {
"node": ">=20.0.0"
}
}

0 comments on commit 2e024f1

Please sign in to comment.