fix(permissions): macos ux improvement #1279

oliverqx · 2025-02-06T02:52:10Z

/claim #1273
/claim #1264

description

this pr will address the following issues: #1273, #1264

goals

implement permission dialog
improve onboarding lifecycle, so it reopens after restarting when permissions are granted. (fixed with feat(tauri): add prod configuration file #1349)
fix permissions showing green when toggled off
fix permission showing green when permission was given to a dev build
hide permission related interfaces form windows/linux
fix mac os unlinking permissions between updates/rebuilds ([bounty] fix macos permission UI #1264)

vercel · 2025-02-06T14:36:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
screenpipe	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 11, 2025 9:26pm

louis030195 · 2025-02-07T18:30:37Z

why is there 26 file changes?

this should be like 3-4 files not more

keep it simple

oliverqx · 2025-02-07T18:36:40Z

@louis030195 ik.. most of those changes are just reorganizing files for better dx:

moved all slides into @/components/onboarding/slides
moved use-onboarding to @/components/onboarding/context
cleaned up context by creating three hooks in @/components/onboarding/hooks
moved flow to its own file
implemented framer motion for slide animation

Its just that while debugging onboarding it was hard to understand its flow, lots of places controlled dialog visibility and user input state. For example, showOnboarding was being set in three different components for different reasons which made onboarding not reopen consistently upon restarting the app

core logic remains the same

with the changes its now really easy to understand when and why showOnboarding is set to false, dialog will reopen at permissions slide when restarting for screen recording permissions

return type of permissions is string, always true. check should be similar to onboarding's status

- moved file into @/components/onboarding - renamed onboarding.tsx to dialog.tsx final result @/components/onboarding/dialog.tsx

- move into @/components/onboarding - rename from use-onboarding to context final result: @/components/onboarding/context

- move all slides from @/components/onboarding to @/components/onboarding/slides

…ons after "request_permission" is invoked this gives user and system time to grant permissions before we trigger a check. Otherwise, function checks prematurely

- use localforage to set showOnboarding - make functions asynchronous

vercel · 2025-02-12T14:18:59Z

@oliverqx is attempting to deploy a commit to the louis030195's projects Team on Vercel.

A member of the Team first needs to authorize it.

- was previously using LAST_AUDIO_CAPTURE from screenpipe-audio/core line 16 which is essentially just a SystemTime::now(). Now using response from state.db.get_latest_timestamps. - lowered threshold from 1 hour to 2 minutes. Seems like if not disabled, the user wouldnt want to wait 1 hour before being notified that nothing is being recorded

…ermissions are broken

oliverqx · 2025-02-14T01:00:40Z

@louis030195 I think this is ready to be reviewed. I know its a lot but here's a quick overview of what I've done:

moved all slides into @/components/onboarding/slides
moved use-onboarding to @/components/onboarding/context
cleaned up context by creating three hooks in @/components/onboarding/hooks
moved flow to its own file
implemented framer motion for slide animation
created use-permissions hook
created screenpipe status context
moved use-health-check into screenpipe status context

especially now that use-health-check is a webhook it's best to keep it in a context instead of mounting the webhook everytime useHealthCheck is called. This way only one webhook is active and receiving updates, all other components can grab both health and permissions information from this context

moved screenpipe status dialog from the status badge component to main page
implemented useEffect to have screenpipe status context open status dialog if permissions are broken or health is compromised
updated health_check in rust backend as it was not giving accurate info about audio (f06a2ab)

id be down to schedule a quick meeting to go over the changes if necessary

restart is handled in useOnboardingVisibility hook

algora-pbc bot mentioned this pull request Feb 6, 2025

[bounty] macos: improve our permission UX #1273

Open

algora-pbc bot added the 🙋 Bounty claim label Feb 6, 2025

vercel bot deployed to Preview February 6, 2025 14:37 View deployment

vercel bot deployed to Preview February 6, 2025 14:38 View deployment

vercel bot deployed to Preview February 6, 2025 14:44 View deployment

vercel bot deployed to Preview February 6, 2025 14:50 View deployment

vercel bot deployed to Preview February 6, 2025 15:00 View deployment

vercel bot deployed to Preview February 6, 2025 15:21 View deployment

vercel bot deployed to Preview February 6, 2025 15:26 View deployment

vercel bot deployed to Preview February 6, 2025 16:04 View deployment

vercel bot deployed to Preview February 6, 2025 17:48 View deployment

vercel bot deployed to Preview February 6, 2025 17:52 View deployment

vercel bot deployed to Preview February 6, 2025 17:59 View deployment

vercel bot deployed to Preview February 7, 2025 14:30 View deployment

vercel bot deployed to Preview February 7, 2025 14:33 View deployment

vercel bot deployed to Preview February 7, 2025 14:44 View deployment

vercel bot deployed to Preview February 7, 2025 15:41 View deployment

vercel bot deployed to Preview February 7, 2025 18:55 View deployment

vercel bot deployed to Preview February 7, 2025 18:59 View deployment

vercel bot deployed to Preview February 7, 2025 19:41 View deployment

vercel bot deployed to Preview February 7, 2025 20:11 View deployment

vercel bot deployed to Preview February 7, 2025 20:17 View deployment

vercel bot deployed to Preview February 7, 2025 21:44 View deployment

oliverqx added 4 commits February 11, 2025 08:20

fix(status): fix permissions check

2f598c7

return type of permissions is string, always true. check should be similar to onboarding's status

refactor(onboarding): move onboarding component

6620cbe

- moved file into @/components/onboarding - renamed onboarding.tsx to dialog.tsx final result @/components/onboarding/dialog.tsx

feat(onboarding): move use-onboarding hook

c71d1bd

- move into @/components/onboarding - rename from use-onboarding to context final result: @/components/onboarding/context

feat(onboarding): move onboarding slides

5186d4f

- move all slides from @/components/onboarding to @/components/onboarding/slides

oliverqx added 3 commits February 11, 2025 09:18

chore(status): remove dead code

494aac4

feat(settings): from settings load data dir and expose it

957f3d1

chore(status-dialog): use localDataDir from useSettings

8b5ae1f

vercel bot deployed to Preview February 11, 2025 15:21 View deployment

oliverqx added 2 commits February 11, 2025 10:07

fix(onboarding): remove screenPermissionRestartPending after restarting

b136ebd

fix(use-permissions): add delay and several triggers to checkPermissi…

cb12cef

…ons after "request_permission" is invoked this gives user and system time to grant permissions before we trigger a check. Otherwise, function checks prematurely

vercel bot deployed to Preview February 11, 2025 16:09 View deployment

Merge branch 'main' into fix.permissions-ux

03e2a3f

vercel bot deployed to Preview February 11, 2025 21:26 View deployment

feat(onboarding): add persistency

c579490

- use localforage to set showOnboarding - make functions asynchronous

oliverqx added 12 commits February 12, 2025 08:19

Merge branch 'main' into fix.permissions-ux

dd0526d

chore(use-health-check): improve types

bf1a665

feat(status): improve status badge

a6c0fd9

fix: use localDataDir instead of function

ff41663

types(health-check): export and use in pipe-store

bea30e6

fix(status-dialog): implement useStatusDialog()

1448c18

feat(screenpip-status): add useEffect to open dialog when status or p…

d031dd3

…ermissions are broken

feat(screenpipe-status): merge badges into one

a4982c2

fix(screenpipe-status): update enum value to match server output

0b24f1d

feat(use-health-check): improve types and remove isServerDown state

e306343

feat(screenpipe-status): let user dismiss error dialog

3bea344

This was referenced Feb 13, 2025

feat(sidecar): add permissions guard before starting sidecar #1348

Open

feat(tauri): add prod configuration file #1349

Open

Merge branch 'main' into fix.permissions-ux

612d631

oliverqx marked this pull request as ready for review February 14, 2025 00:50

oliverqx mentioned this pull request Feb 14, 2025

[bug] empty audio saved when permission is disabled in macos #1350

Open

fix: remove useEffect

f8ede84

restart is handled in useOnboardingVisibility hook

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(permissions): macos ux improvement #1279

fix(permissions): macos ux improvement #1279

oliverqx commented Feb 6, 2025 •

edited

Loading

vercel bot commented Feb 6, 2025 •

edited

Loading

louis030195 commented Feb 7, 2025 •

edited

Loading

oliverqx commented Feb 7, 2025 •

edited

Loading

vercel bot commented Feb 12, 2025

oliverqx commented Feb 14, 2025 •

edited

Loading

fix(permissions): macos ux improvement #1279

Are you sure you want to change the base?

fix(permissions): macos ux improvement #1279

Conversation

oliverqx commented Feb 6, 2025 • edited Loading

description

goals

vercel bot commented Feb 6, 2025 • edited Loading

louis030195 commented Feb 7, 2025 • edited Loading

oliverqx commented Feb 7, 2025 • edited Loading

vercel bot commented Feb 12, 2025

oliverqx commented Feb 14, 2025 • edited Loading

oliverqx commented Feb 6, 2025 •

edited

Loading

vercel bot commented Feb 6, 2025 •

edited

Loading

louis030195 commented Feb 7, 2025 •

edited

Loading

oliverqx commented Feb 7, 2025 •

edited

Loading

oliverqx commented Feb 14, 2025 •

edited

Loading