Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mgconsole with docker examples #994

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

antejavor
Copy link
Contributor

@antejavor antejavor commented Sep 17, 2024

Description

Added information about the new container and my console docker container examples, which include interactive and non-interactive modes.

Release note:
We have introduced a mgconsole Docker container(memgraph/mgconsole#81)

Pull request type

Please check what kind of PR this is:

  • Fix or improvement of an existing page

Related PRs and issues

Closes:
memgraph/mgconsole#83

PR this doc page is related to:
memgraph/mgconsole#81

Checklist:

  • Check all content with Grammarly
  • Perform a self-review of my code
  • Make corresponding changes to the rest of the documentation (consult with the DX team)
  • The build passes locally
  • My changes generate no new warnings or errors
  • Add a corresponding label
  • If release-related, add a product and version label
  • If release-related, add release note on product PR

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 2:26pm

@antejavor antejavor changed the title Add mgconsole docker examples Add mgconsole with docker examples Sep 18, 2024
@antejavor antejavor added status: ready PR is ready for review memgraph-2-20 labels Sep 18, 2024
@antejavor antejavor self-assigned this Sep 18, 2024
@hal-eisen-MG
Copy link
Contributor

In the file pages/getting-started/install-memgraph/docker.mdx there is other references to mgconsole which is still using the memgraph docker container. That should be updated please.
docker exec -it memgraph mgconsole should be updated to use the mgconsole docker image.

@hal-eisen-MG
Copy link
Contributor

hal-eisen-MG commented Sep 21, 2024

In the file pages/getting-started/install-memgraph/docker.mdx
In the example of mgconsole, please bump the version number from 1.3 to 1.4

@hal-eisen-MG
Copy link
Contributor

hal-eisen-MG commented Sep 21, 2024

In the file pages/getting-started/install-memgraph/docker.mdx
And we'll want to update the section on memgraph-platform to also use the new mgconsole docker image, thanks.

@hal-eisen-MG
Copy link
Contributor

There are some conflicts with the upcoming memgraph-2-20 branch

@antejavor
Copy link
Contributor Author

In the file pages/getting-started/install-memgraph/docker.mdx
And we'll want to update the section on memgraph-platform to also use the new mgconsole docker image, thanks.

I think we should delete that part from the documentation about memgrap-platform, the reason being memgraph-platform image is deprecated. We do not want folks to use that type of image, and that is the reason I have ignored that bit of the documentation.

Also, it uses a specific way of starting memgraph and mgconsole, so I didn't want to mess with that. I think it is a good time to delete that. If you agree, we could open a separate PR or issue for that. cc @katarinasupe

@katarinasupe
Copy link
Contributor

I agree with @antejavor regarding mgconsole container and Memgraph Platform. Memgraph platform image is no longer being updated and that part of the docs remained there for those who are still using it (there should be a certain criteria when we decide to remove it).

Regarding mgconsole, maybe we could add it here: https://memgraph.com/docs/getting-started/install-memgraph/docker-compose
Previously Memgraph Platform image would run mgconsole automatically on start. So, if someone wants mgconsole running and if we consider that being the "full Memgraph Platform", then we can consider adding Docker Compose with mgconsole, along with Memgraph MAGE and Lab. Wdyt?

@antejavor
Copy link
Contributor Author

@katarinasupe Since this is more of a product-fit/restructuring decision type of thing, let's do that in another PR, I have open an issue for this: #1021.

@katarinasupe katarinasupe merged commit 00f1dc7 into main Oct 29, 2024
2 checks passed
@katarinasupe katarinasupe deleted the add-mgconsole-docker-examples branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memgraph-2-20 status: ready PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants