Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back removed modules #528

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Bring back removed modules #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
267b65d
bring back removed modules
imilinovic Nov 22, 2024
49478d5
don't run ml tests in without ML build
imilinovic Nov 22, 2024
a016891
fix
imilinovic Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ jobs:
run: |
cd e2e
docker exec -i -u root ${{ env.MAGE_CONTAINER }} bash -c \
"cd /mage/e2e/ && python3 -m pytest . -k 'not cugraph and not node_classification and not link_prediction and not text ${{ inputs.build_scope == 'without ML' && 'and not tgn' || '' }}'"
"cd /mage/e2e/ && python3 -m pytest . -k 'not cugraph ${{ inputs.build_scope == 'without ML' && 'and not tgn and not node_classification and not link_prediction' || '' }}'"

- name: Run End-to-end correctness tests
if: inputs.arch != 'arm64'
Expand Down
8 changes: 1 addition & 7 deletions Dockerfile.release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ RUN git clone --recurse-submodules -b 0.9.x https://github.com/dmlc/dgl.git \
&& cd dgl && mkdir build && cd build && cmake .. \
&& make -j4 && cd ../python && python3 setup.py install

# Needs to be here and in prod phase
# Remove modules with issues
RUN rm /usr/lib/memgraph/query_modules/node_classification.py \
&& rm /usr/lib/memgraph/query_modules/link_prediction.py \
&& rm /usr/lib/memgraph/query_modules/text.so

USER memgraph
ENTRYPOINT ["/usr/lib/memgraph/memgraph"]
CMD [""]
Expand Down Expand Up @@ -103,7 +97,7 @@ RUN mv /mage/e2e /e2e/ \
&& export PATH="/usr/local/lib/python${PY_VERSION}:${PATH}" \
&& apt-get -y --purge autoremove clang git curl python3-pip python3-dev cmake build-essential \
&& apt-get clean


USER memgraph
ENTRYPOINT ["/usr/lib/memgraph/memgraph"]
Expand Down