Skip to content

Commit

Permalink
remove all deprecated functionality
Browse files Browse the repository at this point in the history
This emerged in the context of #364. We remove all deprecated
functionality. All of this has been deprecated for at least a year, so
the impact should not be too big. (Anyway, since this is potentially
breaking change, the next odxtools release after this patch will be
9.0.0)

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Gerrit Ecke <[email protected]>
  • Loading branch information
andlaus committed Nov 26, 2024
1 parent 39cf659 commit 8dabcfe
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 39 deletions.
10 changes: 0 additions & 10 deletions odxtools/diaglayers/hierarchyelement.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
Union, cast)
from xml.etree import ElementTree

from deprecation import deprecated

from ..additionalaudience import AdditionalAudience
from ..admindata import AdminData
from ..comparaminstance import ComparamInstance
Expand Down Expand Up @@ -724,10 +722,6 @@ def get_can_receive_id(self,

return int(result)

@deprecated(details="use get_can_receive_id()") # type: ignore[misc]
def get_receive_id(self) -> Optional[int]:
return self.get_can_receive_id()

def get_can_send_id(self, protocol: Optional[Union[str, "Protocol"]] = None) -> Optional[int]:
"""CAN ID to which the ECU sends replies to diagnostic messages"""

Expand All @@ -753,10 +747,6 @@ def get_can_send_id(self, protocol: Optional[Union[str, "Protocol"]] = None) ->

return int(result)

@deprecated(details="use get_can_send_id()") # type: ignore[misc]
def get_send_id(self) -> Optional[int]:
return self.get_can_send_id()

def get_can_func_req_id(self,
protocol: Optional[Union[str, "Protocol"]] = None) -> Optional[int]:
"""CAN Functional Request Id."""
Expand Down
7 changes: 0 additions & 7 deletions odxtools/inputparam.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from typing import Any, Dict, List, Optional
from xml.etree import ElementTree

from deprecation import deprecated

from .dopbase import DopBase
from .element import NamedElement
from .exceptions import odxrequire
Expand Down Expand Up @@ -49,8 +47,3 @@ def _resolve_snrefs(self, context: SnRefContext) -> None:
def dop_base(self) -> DopBase:
"""The data object property describing this parameter."""
return self._dop_base

@property
@deprecated(details="use .dop_base") # type: ignore[misc]
def dop(self) -> DopBase:
return self._dop_base
7 changes: 0 additions & 7 deletions odxtools/message.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
from dataclasses import dataclass
from typing import TYPE_CHECKING, Union

from deprecation import deprecated

from .odxtypes import ParameterValue, ParameterValueDict

if TYPE_CHECKING:
Expand All @@ -29,8 +27,3 @@ class Message:

def __getitem__(self, key: str) -> ParameterValue:
return self.param_dict[key]

@property
@deprecated("use .coding_object") # type: ignore[misc]
def structure(self) -> Union["Request", "Response"]:
return self.coding_object
7 changes: 0 additions & 7 deletions odxtools/outputparam.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from typing import Any, Dict, List, Optional
from xml.etree import ElementTree

from deprecation import deprecated

from .dopbase import DopBase
from .element import IdentifiableElement
from .exceptions import odxrequire
Expand Down Expand Up @@ -40,8 +38,3 @@ def _resolve_snrefs(self, context: SnRefContext) -> None:
def dop_base(self) -> DopBase:
"""The data object property describing this parameter."""
return self._dop_base

@property
@deprecated(details="use .dop_base") # type: ignore[misc]
def dop(self) -> DopBase:
return self._dop_base
8 changes: 0 additions & 8 deletions odxtools/uds.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
from itertools import chain
from typing import Optional

from deprecation import deprecated

import odxtools.obd as obd


Expand Down Expand Up @@ -170,9 +168,3 @@ def is_response_pending(telegram_payload: bytes, request_sid: Optional[int] = No

# if all of the above applies, we received a "stay tuned" response
return True


# previous versions of odxtools had a typo here. hit happens!
@deprecated(details="use is_response_pending()") # type: ignore[misc]
def is_reponse_pending(telegram_payload: bytes, request_sid: Optional[int] = None) -> bool:
return is_response_pending(telegram_payload, request_sid)

0 comments on commit 8dabcfe

Please sign in to comment.