Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pcfile, library versioning, and enabled installation #13

Open
wants to merge 1 commit into
base: 7.0.1
Choose a base branch
from

Conversation

vedranmiletic
Copy link

No description provided.

@eli-schwartz
Copy link
Member

I don't understand the point of installing headers or pkg-config files.

This does solve #6 though I would suggest only installing the library if default_library is shared or both.

@vedranmiletic
Copy link
Author

Apologies for the delay.

I don't understand the point of installing headers or pkg-config files.

Your project libraries get linked to libfmt.so from the wrap that gets built.

This does solve #6 though I would suggest only installing the library if default_library is shared or both.

Makes sense. Fixed.

@jpakkane
Copy link
Member

Sorry for the delay, just saw this in the notification area. Nowadays wraps should have a [provide] entry. With that added this should be good to merge.

@eli-schwartz
Copy link
Member

Now that we're getting a meson install flag to skip installing subprojects, I'm less bothered by an addition like this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants