Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: put back mesonpy.__version__ #719

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

dnicolodi
Copy link
Member

@dnicolodi dnicolodi commented Jan 27, 2025

The module constant has been used to check meson-python version in other projects, see discussion on #691. Add a test to ensure that the version recorded in pyproject.toml and mesonpy/__init__.py are kept in sync.

@dnicolodi dnicolodi force-pushed the version-dunder branch 4 times, most recently from c7db252 to 3d230c7 Compare January 27, 2025 16:36
@dnicolodi
Copy link
Member Author

I would really like to know why CirrusCI gets stuck sometimes until the docker images are refreshed

The module constant has been used to check meson-python version in
other projects, see discussion on mesonbuild#691.  Add a test to ensure that the
version recorded in pyproject.toml and mesonpy/__init__.py are kept in
sync.
@rgommers rgommers added this to the v0.18.0 milestone Jan 28, 2025
@rgommers rgommers added the maintenance Regular code improvements that are not new features nor end-user-visible bugs label Jan 28, 2025
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @dnicolodi!

@rgommers rgommers merged commit f0c7a42 into mesonbuild:main Jan 28, 2025
40 checks passed
@ianthomas23
Copy link

Thanks for putting this back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Regular code improvements that are not new features nor end-user-visible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants