BulkLoadDemo Display Fix #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ShowingASet" state tracked time since loading the Marc file, not since loading finished. If the demo takes, say, 20 seconds to load, this state lasts only briefly before switching to "Unloading." To ensure a consistent 10-second display, we now consider both load time and display duration.
|
@HaydnTrigg, thank you for your contribution. This behavior is actually by design since it allows for side-by-side comparisons to be made. If you'd consider making this behavior controllable by some kind of a runtime setting then I'd be happy to integrate this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "ShowingASet" state tracked time since loading the Marc file, not since loading finished. If the demo takes, say, 20 seconds to load, this state lasts only briefly before switching to "Unloading." To ensure a consistent 10-second display, we now consider both load time and display duration.