-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Ut 10888 backend #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Title: Implement Unit Testing for Remaining Backend Code
This pull request includes several updates to the codebase, primarily focusing on standardizing import paths, modifying GitHub workflows, and updating configuration files. Below are the most important changes:
Standardizing Import Paths:
src.backend
for consistency. (src/backend/agents/agentutils.py
,src/backend/agents/base_agent.py
,src/backend/agents/generic.py
,src/backend/agents/group_chat_manager.py
,src/backend/agents/hr.py
,src/backend/agents/human.py
,src/backend/agents/marketing.py
,src/backend/agents/planner.py
,src/backend/agents/procurement.py
,src/backend/agents/product.py
,src/backend/agents/tech_support.py
,src/backend/app.py
,src/backend/context/cosmos_memory.py
) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Modifying GitHub Workflows:
docker-build-and-push.yml
workflow to use${{ github.head.ref }}
instead of${{ github.ref }}
for setting Docker image tags. (.github/workflows/docker-build-and-push.yml
)pip install pytest-cov
andpip install pytest-asyncio
commands from the test workflow. (.github/workflows/test.yml
) [1] [2]Configuration File Updates:
E402
to the list of ignored errors in the.flake8
configuration file. (.flake8
)These changes aim to improve the consistency and maintainability of the codebase, streamline the CI/CD workflows, and update the linting configuration.
Description: We have shortlisted the framework for unit testing for the backend code, and we have successfully created unit tests for some of the backend files. These unit tests have already been integrated with the CI pipeline. Our current work involves creating unit test coverage for the remaining backend files of Business in a Box.
Scope:
![image](https://private-user-images.githubusercontent.com/182071378/408990552-f09c6ed2-7e45-44e4-847f-6f7bf315e16c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTM3MTIsIm5iZiI6MTczODk5MzQxMiwicGF0aCI6Ii8xODIwNzEzNzgvNDA4OTkwNTUyLWYwOWM2ZWQyLTdlNDUtNDRlNC04NDdmLTZmN2JmMzE1ZTE2Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwNTQzMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lZjJiZGJlOWVlNmQ4MGZiNjIwYjlkODk5NjRlOTI1ZTBlYTk0MTQ3MTdjMjNkNTg1OGRlY2ViNjU2ZmQzM2Q5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.5Q_QoYrvHDLhRpu6R4iSgJhVsY6v8yNTCrqtfsBR9Fc)
Completed -
Screen Shot of coverage 84%
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information