Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ut 10888 backend #40

Merged
merged 176 commits into from
Feb 3, 2025
Merged

test: Ut 10888 backend #40

merged 176 commits into from
Feb 3, 2025

Conversation

UtkarshMishra-Microsoft
Copy link

@UtkarshMishra-Microsoft UtkarshMishra-Microsoft commented Jan 15, 2025

Purpose

Title: Implement Unit Testing for Remaining Backend Code
This pull request includes several updates to the codebase, primarily focusing on standardizing import paths, modifying GitHub workflows, and updating configuration files. Below are the most important changes:

Standardizing Import Paths:

  • Updated import paths in various agent files to use src.backend for consistency. (src/backend/agents/agentutils.py, src/backend/agents/base_agent.py, src/backend/agents/generic.py, src/backend/agents/group_chat_manager.py, src/backend/agents/hr.py, src/backend/agents/human.py, src/backend/agents/marketing.py, src/backend/agents/planner.py, src/backend/agents/procurement.py, src/backend/agents/product.py, src/backend/agents/tech_support.py, src/backend/app.py, src/backend/context/cosmos_memory.py) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Modifying GitHub Workflows:

  • Updated the docker-build-and-push.yml workflow to use ${{ github.head.ref }} instead of ${{ github.ref }} for setting Docker image tags. (.github/workflows/docker-build-and-push.yml)
  • Removed redundant pip install pytest-cov and pip install pytest-asyncio commands from the test workflow. (.github/workflows/test.yml) [1] [2]

Configuration File Updates:

  • Added E402 to the list of ignored errors in the .flake8 configuration file. (.flake8)

These changes aim to improve the consistency and maintainability of the codebase, streamline the CI/CD workflows, and update the linting configuration.

Description: We have shortlisted the framework for unit testing for the backend code, and we have successfully created unit tests for some of the backend files. These unit tests have already been integrated with the CI pipeline. Our current work involves creating unit test coverage for the remaining backend files of Business in a Box.


Scope:
Completed -
Screen Shot of coverage 84%
image

image

image

  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit f8640d9 into hotfix Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants