Apply suggestions from code review

microsoft · Dec 13, 2023 · 0ed8e45 · 0ed8e45
1 parent e585f4c
commit 0ed8e45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/Microsoft.OpenApi/Helpers/SchemaSerializerHelper.cs b/src/Microsoft.OpenApi/Helpers/SchemaSerializerHelper.cs
@@ -18,6 +18,7 @@ internal static void WriteAsItemsProperties(JsonSchema schema,
                                                     IDictionary<string, IOpenApiExtension> extensions,
                                                     OpenApiSpecVersion version)
         {
+            Utils.CheckArgumentNull(writer);
             // type
             if (schema.GetJsonType() != null)
             {

diff --git a/src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs b/src/Microsoft.OpenApi/Writers/OpenApiWriterBase.cs
@@ -592,14 +592,14 @@ public void WriteJsonSchemaWithoutReference(IOpenApiWriter writer, JsonSchema sc
         }
 
         /// <inheritdoc />
-        public void WriteJsonSchemaReference(IOpenApiWriter writer, Uri referenceUri, OpenApiSpecVersion version)
+        public void WriteJsonSchemaReference(IOpenApiWriter writer, Uri reference, OpenApiSpecVersion version)
         {
-            var reference = version.Equals(OpenApiSpecVersion.OpenApi2_0)
-                ? referenceUri.OriginalString.Replace("components/schemas", "definitions")
-                : referenceUri.OriginalString;
+            var referenceItem = version.Equals(OpenApiSpecVersion.OpenApi2_0)
+                ? reference.OriginalString.Replace("components/schemas", "definitions")
+                : reference.OriginalString;
 
             WriteStartObject();
-            this.WriteProperty(OpenApiConstants.DollarRef, reference);
+            this.WriteProperty(OpenApiConstants.DollarRef, referenceItem);
             WriteEndObject();
         }
     }