fix/reference copy #2046
Draft
fix/reference copy #2046
+370
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| internal class CopyReferences : OpenApiVisitorBase | ||
| private readonly OpenApiDocument _target = target; | ||
| public OpenApiComponents Components = new(); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note
|
@MaggieKimani1 I just had a thought: we could define a generic IOpenApiReferenceable interface, that derives from the existing interface, and defines the target property. Thoughts? |
Yeah this seems like a cleaner approach for designing the proxy classes. Let me implement this. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial #1998