fix: Disable telemetry adaptive sampling (#6849)

* disable adaptive sampling * using Microsoft.ApplicationInsights.AspNetCore.Extensions
microsoft · Sep 17, 2024 · 6d584df · 6d584df
1 parent c11b7fd
commit 6d584df
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/.../Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime/Extensions/ServiceCollectionExtensions.cs b/.../Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime/Extensions/ServiceCollectionExtensions.cs
@@ -209,6 +209,7 @@ internal static void AddBotRuntimeTelemetry(this IServiceCollection services, IC
             }
             else
             {
+                telemetrySettings.Options.EnableAdaptiveSampling = false;
                 services.AddApplicationInsightsTelemetry(telemetrySettings.Options);
                 services.TryAddSingleton<IBotTelemetryClient, BotTelemetryClient>();
 

diff --git a/...Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ServiceCollectionExtensions.cs b/...Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ServiceCollectionExtensions.cs
@@ -5,6 +5,7 @@
 using System;
 using System.Linq;
 using Microsoft.ApplicationInsights;
+using Microsoft.ApplicationInsights.AspNetCore.Extensions;
 using Microsoft.ApplicationInsights.Extensibility;
 using Microsoft.Bot.Builder.ApplicationInsights;
 using Microsoft.Bot.Configuration;
@@ -57,7 +58,14 @@ public static IServiceCollection AddBotApplicationInsights(this IServiceCollecti
             IBotTelemetryClient telemetryClient = null;
             if (appInsightService != null)
             {
-                services.AddApplicationInsightsTelemetry(appInsightService.InstrumentationKey);
+                // Create Application Insights options and disable adaptive sampling
+                var aiOptions = new ApplicationInsightsServiceOptions
+                {
+                    EnableAdaptiveSampling = false,
+                    InstrumentationKey = appInsightService.InstrumentationKey
+                };
+
+                services.AddApplicationInsightsTelemetry(aiOptions);
                 telemetryClient = new BotTelemetryClient(new TelemetryClient());
             }
             else
@@ -88,9 +96,19 @@ public static IServiceCollection AddBotApplicationInsights(this IServiceCollecti
             CreateBotTelemetry(services);
 
             IBotTelemetryClient telemetryClient = null;
+
             if (!string.IsNullOrWhiteSpace(instrumentationKey))
             {
-                services.AddApplicationInsightsTelemetry(instrumentationKey);
+                // Create Application Insights options and disable adaptive sampling
+                var aiOptions = new ApplicationInsightsServiceOptions
+                {
+                    EnableAdaptiveSampling = false, 
+                    InstrumentationKey = instrumentationKey
+                };
+
+                // Add Application Insights telemetry with custom options
+                services.AddApplicationInsightsTelemetry(aiOptions);
+
                 telemetryClient = new BotTelemetryClient(new TelemetryClient());
             }
             else
@@ -122,7 +140,14 @@ public static IServiceCollection AddBotApplicationInsights(this IServiceCollecti
             // Start Application Insights
             if (instrumentationKey != null)
             {
-                services.AddApplicationInsightsTelemetry(instrumentationKey);
+                // Create Application Insights options and disable adaptive sampling
+                var aiOptions = new ApplicationInsightsServiceOptions
+                {
+                    EnableAdaptiveSampling = false,
+                    InstrumentationKey = instrumentationKey
+                };
+
+                services.AddApplicationInsightsTelemetry(aiOptions);
             }
 
             // Register the BotTelemetryClient
-Original file line number
+Diff line change
@@ Expand Up @@
                 }
                 else
                 {
+                    telemetrySettings.Options.EnableAdaptiveSampling = false;
                     services.AddApplicationInsightsTelemetry(telemetrySettings.Options);
                     services.TryAddSingleton<IBotTelemetryClient, BotTelemetryClient>();
@@ Expand Down @@