fix: Add Audience for Certificate auth to work with Skills #6794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR adds Audience to CertificateAppCredentials, so it is passed correctly when calling a Skill bot. Additionally, these changes take into consideration the PR #6694, so the improvement isn't lost in the process.
Specific Changes
oAuthScope
parameter tolibraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs
.libraries/Microsoft.Bot.Connector/Authentication/CertificateServiceClientCredentialsFactory.cs
by reverting the changes made in the PR Support SN+I authentication with AAD #6694, but maintaining the improvement.CertificateAppCredentials
per Audience, instead of having just one with the defaultapi.botframework
.Testing
The following images show the new unit test passing and the Root + Skill bots working as expected.
![image](https://private-user-images.githubusercontent.com/62260472/332914135-c02bea3e-3d48-4379-a049-b58f43bd233b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODM3ODQsIm5iZiI6MTczOTU4MzQ4NCwicGF0aCI6Ii82MjI2MDQ3Mi8zMzI5MTQxMzUtYzAyYmVhM2UtM2Q0OC00Mzc5LWEwNDktYjU4ZjQzYmQyMzNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAxMzgwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3YzVjODBiYzEyNTQyODBiZGQ4NjNmZjRhN2JmODI0NmQyODI2MWIxNDQ0YWJlODA3YjZlMGE5N2IxMzJjMDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.316B2Ydof5J7ctvZCMiHMJOssxwHN0c71qqrJsNcGW0)
![image](https://private-user-images.githubusercontent.com/62260472/332914453-d781e1c5-7226-4da7-926e-c86d100b08f1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODM3ODQsIm5iZiI6MTczOTU4MzQ4NCwicGF0aCI6Ii82MjI2MDQ3Mi8zMzI5MTQ0NTMtZDc4MWUxYzUtNzIyNi00ZGE3LTkyNmUtYzg2ZDEwMGIwOGYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAxMzgwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM5OGQwMDI2ZDhkNjRlZjE5MzA0MDIyY2M2ZThhYTVmMmQxMmE1Y2YxNzMzNjUzZGRmZTViNzdhYzBlOWU5ZTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.PJpI3szoSAqFJpXHAFUqJvSGpCHoWRJLxxBsXA-5Ycs)