[#6771] Fix Attachment issue when it has a MemoryStream instance #6850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6771
Description
This PR fixes an issue with DLASE when a MemoryStream instance is being used as an Activity.Attachment, e.g. a file. The ReadTimeout issue is caused when trying to serialize the non-serializable MemoryStream instance.
Specific Changes
AttachmentMemoryStreamConverter
to serialize and deserialize a MemoryStream instance.Testing
The following images show the bot working, and the unit tests passing.
![image](https://private-user-images.githubusercontent.com/62260472/368221839-6c33b5ae-b93e-4be7-a7a0-059c7e2aa521.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODA4MjcsIm5iZiI6MTczOTU4MDUyNywicGF0aCI6Ii82MjI2MDQ3Mi8zNjgyMjE4MzktNmMzM2I1YWUtYjkzZS00YmU3LWE3YTAtMDU5YzdlMmFhNTIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAwNDg0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA4YmU1ZDUwNWYxOTkzMTA4NzM3NDI2MjZlMzhhYTQzNmY3YWMxY2UwNWI2YmY3MGFhY2VmY2NmYWVlNDg5YmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.eJkGF1g5s5_JWRnOXyhyd2bH079aix7KHsu23WIvQlU)
![image](https://private-user-images.githubusercontent.com/62260472/368221983-21865205-1551-4a2a-aa8a-1727b9cbd6c1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODA4MjcsIm5iZiI6MTczOTU4MDUyNywicGF0aCI6Ii82MjI2MDQ3Mi8zNjgyMjE5ODMtMjE4NjUyMDUtMTU1MS00YTJhLWFhOGEtMTcyN2I5Y2JkNmMxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAwNDg0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIzMDQ0NmE1ODVjZGJiZGRiMzhhYmY0MmNkNWRjZDAyNDYxNzdhMzE0ZDg5OTEwZjg4ZmZhMzA0YWFkNTljZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Z5JFuTI7q_15EShzVujvhpk59zjOFnHOMTNYAE8lRrc)