Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unauthorized files / dirs for cleanup #1328

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

pauld-msft
Copy link
Member

Issue reported by customer. Agents that do not even have read access to some parts of the file system can run into issues when trying to determine the files and directories that need to be cleaned up.

Fix: error handle the unauthorized exception, and skip cleanup for those cases

@pauld-msft pauld-msft requested a review from a team as a code owner December 18, 2024 15:11
@pauld-msft pauld-msft requested a review from cobya December 18, 2024 15:11
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 81.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (91378b6) to head (0815de3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tion.Contracts/FileComponentDetectorWithCleanup.cs 69.5% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1328   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        384     384           
  Lines      29930   29963   +33     
  Branches    1835    1835           
=====================================
+ Hits       26842   26875   +33     
- Misses      2696    2698    +2     
+ Partials     392     390    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 21, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@pauld-msft pauld-msft enabled auto-merge (squash) January 21, 2025 20:21
@pauld-msft pauld-msft merged commit 269fb53 into main Jan 21, 2025
23 of 25 checks passed
@pauld-msft pauld-msft deleted the pauldorsch/fix-cleanup-error-handling branch January 21, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants