Make FluentTextArea.Appearance nullable

Updated FluentTextArea.Appearance to be nullable, removing the default value. Adjusted related test files to reflect this change by removing the `appearance="outline"` attribute. Cleaned up `Components.Tests.csproj` by removing unnecessary `<None>` items. Updated multiple test verification files to align with the new nullable property.
microsoft · Feb 11, 2025 · 21d21a7 · 21d21a7
1 parent 8791f94
commit 21d21a7
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 23 deletions.
diff --git a/src/Core/Components/TextArea/FluentTextArea.razor.cs b/src/Core/Components/TextArea/FluentTextArea.razor.cs
@@ -42,7 +42,7 @@ public FluentTextArea()
     /// Gets or sets the visual appearance.
     /// </summary>
     [Parameter]
-    public TextAreaAppearance Appearance { get; set; } = TextAreaAppearance.Outline;
+    public TextAreaAppearance? Appearance { get; set; }
 
     /// <summary>
     /// Gets or sets the short hint displayed in the textarea before the user enters a value.

diff --git a/tests/Core/Components.Tests.csproj b/tests/Core/Components.Tests.csproj
@@ -71,18 +71,5 @@
       <AutoGen>True</AutoGen>
       <DependentUpon>FluentLocalizer.resx</DependentUpon>
     </Compile>
-  </ItemGroup>
-
-  <ItemGroup>
-    <None Update="Components\TextArea\FluentTextAreaTests.FluentInputText_Default.verified.razor.html">
-      <DependentUpon>FluentTextAreaTests.razor</DependentUpon>
-    </None>
-    <None Update="Components\TextArea\FluentTextAreaTests.FluentInputText_LabelTemplate.verified.razor.html">
-      <DependentUpon>FluentTextAreaTests.razor</DependentUpon>
-    </None>
-    <None Update="Components\TextArea\FluentTextAreaTests.FluentInputText_StartEndTemplate.verified.razor.html">
-      <DependentUpon>FluentTextAreaTests.razor</DependentUpon>
-    </None>
-  </ItemGroup>
-
+  </ItemGroup>  
 </Project>
diff --git a/...ore/Components/TextArea/FluentTextAreaTests.FluentTextArea_AutoResize.verified.razor.html b/...ore/Components/TextArea/FluentTextAreaTests.FluentTextArea_AutoResize.verified.razor.html
@@ -1,3 +1,3 @@
 <fluent-field id="xxx" label-position="above">
-    <fluent-textarea appearance="outline" auto-resize id="xxx" slot="input"></fluent-textarea>
+    <fluent-textarea auto-resize id="xxx" slot="input"></fluent-textarea>
 </fluent-field>
diff --git a/tests/Core/Components/TextArea/FluentTextAreaTests.FluentTextArea_Block.verified.razor.html b/tests/Core/Components/TextArea/FluentTextAreaTests.FluentTextArea_Block.verified.razor.html
@@ -1,3 +1,3 @@
 <fluent-field id="xxx" label-position="above">
-    <fluent-textarea appearance="outline" block id="xxx" slot="input"></fluent-textarea>
+    <fluent-textarea block id="xxx" slot="input"></fluent-textarea>
 </fluent-field>
diff --git a/.../Components/TextArea/FluentTextAreaTests.FluentTextArea_LabelTemplate.verified.razor.html b/.../Components/TextArea/FluentTextAreaTests.FluentTextArea_LabelTemplate.verified.razor.html
@@ -3,5 +3,5 @@
   <label id="xxx" slot="label" for="xxx">
     <div style="font-weight: bold;">My label</div>
   </label>
-  <fluent-textarea appearance="outline" id="xxx" slot="input" blazor:onfocusout="1" blazor:onchange="2" blazor:oninput="3" blazor:elementreference="xxx"></fluent-textarea>
+  <fluent-textarea id="xxx" slot="input" blazor:onfocusout="1" blazor:onchange="2" blazor:oninput="3" blazor:elementreference="xxx"></fluent-textarea>
 </fluent-field>
diff --git a/tests/Core/Components/TextArea/FluentTextAreaTests.razor b/tests/Core/Components/TextArea/FluentTextAreaTests.razor
@@ -58,7 +58,7 @@
 
         // Assert
         cut.Find("fluent-textarea")
-           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" appearance=\"outline\" resize=\"{expectedAttribute}\" />");
+           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" resize=\"{expectedAttribute}\" />");
     }
 
     [Theory]
@@ -73,7 +73,7 @@
 
         // Assert
         cut.Find("fluent-textarea")
-            .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" appearance=\"outline\" size=\"{expectedAttribute}\" />");
+            .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\"  size=\"{expectedAttribute}\" />");
     }
 
     [Fact]
@@ -140,7 +140,7 @@
         // Assert
         Assert.Equal("new value", value);
         cut.Find("fluent-textarea")
-           .MarkupMatches("<fluent-textarea id=\"myId\" slot=\"input\" appearance=\"outline\" value=\"new value\" />");
+           .MarkupMatches("<fluent-textarea id=\"myId\" slot=\"input\" value=\"new value\" />");
     }
 
     [Theory]
@@ -160,13 +160,13 @@
         // Assert: Immediate
         Assert.Equal(expectedImmediateValue, value);
         cut.Find("fluent-textarea")
-           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" appearance=\"outline\" value=\"{expectedImmediateValue}\" />");
+           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" value=\"{expectedImmediateValue}\" />");
 
         // Assert: After a small delay
         await Task.Delay(200);
         Assert.Equal(expectedDelayedValue, value);
         cut.Find("fluent-textarea")
-           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" appearance=\"outline\" value=\"{expectedDelayedValue}\" />");
+           .MarkupMatches($"<fluent-textarea id=\"myId\" slot=\"input\" value=\"{expectedDelayedValue}\" />");
     }
 
     [Theory]