Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README files, remove "dead" config types #1343

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Update README files, remove "dead" config types #1343

merged 4 commits into from
Mar 31, 2022

Conversation

afoxman
Copy link
Contributor

@afoxman afoxman commented Mar 31, 2022

Description

This PR tactically updates README files that need a little (or a lot) of help. It also removes two "dead" config types.

  • @rnx-kit/rn-changelog-generator README doesn't use package name as title
  • @rnx-kit/eslint-plugin doesn't have badges
  • @rnx-kit/config is outdated
  • @rnx-kit/cli needs example configs and commands
  • @rnx-kit/typescript-react-native-compiler -- expand on it and show that it is tsc + platform
  • Remove platform bundle config (never used) and dependency list (replaced with capabilities list)

Resolves #1252

Test plan

@afoxman afoxman requested review from JasonVMo and tido64 as code owners March 31, 2022 17:20
@github-actions github-actions bot added feature: cli This is related to CLI feature: eslint This is related to ESLint labels Mar 31, 2022
tido64
tido64 reviewed Mar 31, 2022
View reviewed changes
.changeset/large-geese-share.md Outdated Show resolved Hide resolved
packages/cli/README.md Outdated Show resolved Hide resolved
packages/cli/README.md Outdated Show resolved Hide resolved
packages/typescript-react-native-compiler/README.md Outdated Show resolved Hide resolved
packages/config/README.md Show resolved Hide resolved
@afoxman afoxman enabled auto-merge (squash) March 31, 2022 17:50
@afoxman afoxman merged commit e81d50d into main Mar 31, 2022
@afoxman afoxman deleted the afoxman/readme branch March 31, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

@kelset kelset kelset approved these changes

@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees
No one assigned
Labels
feature: cli This is related to CLI feature: eslint This is related to ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update READMEs
3 participants
@afoxman @tido64 @kelset