-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Auth Options: User-Managed Identity, System-Managed Identity, and AzDO Workload Identity Federation #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/microsoft/terraform-provider-power-platform into ianjensenisme/243-Managed-Identity
I clearly don't understand changie but maybe this will make it happy
mawasile
requested changes
Jan 6, 2025
mattdot
previously approved these changes
Jan 28, 2025
mawasile
previously approved these changes
Jan 29, 2025
mawasile
previously approved these changes
Feb 4, 2025
Co-authored-by: mawasile <[email protected]>
Co-authored-by: mawasile <[email protected]>
Co-authored-by: mawasile <[email protected]>
Co-authored-by: mawasile <[email protected]>
mattdot
previously approved these changes
Feb 4, 2025
Co-authored-by: mawasile <[email protected]>
Co-authored-by: mawasile <[email protected]>
mawasile
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new authentication methods and updates the documentation accordingly. The main changes include adding support for Managed Identity and Azure DevOps Workload Identity Federation authentication, along with corresponding updates to the documentation and tests.
Authentication Methods Added:
internal/api/auth.go
).internal/api/auth.go
).Documentation Updates:
docs/index.md
to include new sections for Managed Identity and Workload Identity Federation authentication methods. [1] [2] [3] [4]docs/index.md
).Configuration Changes:
ProviderConfig
struct to include new fields for Managed Identity and Azure DevOps Workload Identity Federation (internal/config/config.go
). [1] [2]internal/config/config.go
). [1] [2]Tests:
internal/api/client_test.go
).Changelog:
.changes/unreleased/added-20241218.yaml
).This pull request introduces new authentication methods for the Power Platform provider in Terraform. The key changes include adding support for Managed Identity and Workload Identity Federation, along with the necessary configuration updates and new methods for handling these authentication mechanisms.Documentation Updates:
docs/index.md
. [1] [2] [3]Codebase Enhancements:
internal/api/auth.go
to handle authentication using User-Managed Identity, System-Managed Identity, and Azure DevOps Workload Identity Federation. [1] [2]Configuration Changes:
UseMsi
andAzDOServiceConnectionID
to theProviderConfig
struct ininternal/config/config.go
and updated related methods to check for these configurations. [1] [2] [3] [4] [5]Environment Variables:
POWER_PLATFORM_USE_MSI
andPOWER_PLATFORM_AZDO_SERVICE_CONNECTION_ID
ininternal/constants/constants.go
. (internal/constants/constants.goR112-R117, F52f86bdL162R162)Provider Configuration:
internal/provider/provider.go
to include the new authentication options. [1] [2] [3]