powerplatform environment group rule set issue with sending ruleset #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
mattdot
requested changes
Jan 27, 2025
Co-authored-by: Matt Dotson <[email protected]>
mattdot
approved these changes
Jan 30, 2025
…_rule_set-issue-with-sending-ruleset
…_rule_set-issue-with-sending-ruleset
…_rule_set-issue-with-sending-ruleset
mattdot
deleted the
mawasile/564-powerplatform_environment_group_rule_set-issue-with-sending-ruleset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to update date formatting and improve the schema handling in the environment services. The most important changes are:
Date formatting update:
internal/services/environment_group_rule_set/dto.go: Updated theconvertMakerWelcomeContentfunction to usetime.RFC3339instead oftime.RFC1123for date formatting.Schema handling improvement:
internal/services/environment_settings/resources_environment_settings.go: Modified theSchemafunction inEnvironmentSettingsResourceto includestringplanmodifier.UseStateForUnknown()in theidattribute'sPlanModifiers.