Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eduardodfmex/116 solution checker for managed environments #567

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

eduardodfmex
Copy link
Contributor

This pull request introduces a new attribute, solution_checker_rule_overrides, to the ManagedEnvironmentResource model and updates the relevant schema, configuration, and tests to support this new attribute.

Key changes include:

Model Update:

  • Added solution_checker_rule_overrides to the ManagedEnvironmentResourceModel struct in internal/services/managed_environment/models.go.

Schema Update:

  • Added solution_checker_rule_overrides to the schema definition in internal/services/managed_environment/resource_managed_environment.go, including its description, markdown description, requirement status, and validators.

Configuration Update:

  • Updated the Configure method in internal/services/managed_environment/resource_managed_environment.go to handle the new attribute and added error handling for unexpected resource configuration types.

Test Updates:

@eduardodfmex eduardodfmex linked an issue Jan 28, 2025 that may be closed by this pull request
13 tasks
github-actions[bot] added 2 commits January 28, 2025 17:56
Copy link
Member

@mattdot mattdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you work on testing, make sure to add some negative tests that use invalid configuration values and force your validator to fail.

@eduardodfmex eduardodfmex self-assigned this Jan 30, 2025
@eduardodfmex eduardodfmex marked this pull request as ready for review January 30, 2025 00:18
@eduardodfmex eduardodfmex marked this pull request as draft January 30, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Solution Checker for Managed Environments
2 participants