Fix InvokeTestingPlatformTask to handle running with msbuild.exe and 'Test' target #4840

Youssef1313 · 2025-01-30T12:30:30Z

…'Test' target

Evangelink · 2025-01-31T10:06:30Z

@Youssef1313 don't forget to link the ticket

Youssef1313 · 2025-01-31T12:41:45Z

2025-01-31T12:10:37.0321498Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: The specified task executable "dotnet.exe" could not be run. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Win32.Registry, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0416885Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) The specified task executable "dotnet.exe" could not be run. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Win32.Registry, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0437432Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: File name: 'Microsoft.Win32.Registry, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0547738Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) File name: 'Microsoft.Win32.Registry, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0587726Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: at Microsoft.Testing.Platform.MSBuild.Tasks.DotnetMuxerLocator.GetMuxerFromGlobalRegistrationWin(PlatformArchitecture targetArchitecture) [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0619621Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Testing.Platform.MSBuild.Tasks.DotnetMuxerLocator.GetMuxerFromGlobalRegistrationWin(PlatformArchitecture targetArchitecture) [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0629522Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: at Microsoft.Testing.Platform.MSBuild.Tasks.DotnetMuxerLocator.TryGetDotnetPathByArchitecture(PlatformArchitecture targetArchitecture, String& muxerPath) in /_/src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/DotnetMuxerLocator.cs:line 130 [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0658380Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Testing.Platform.MSBuild.Tasks.DotnetMuxerLocator.TryGetDotnetPathByArchitecture(PlatformArchitecture targetArchitecture, String& muxerPath) in /_/src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/DotnetMuxerLocator.cs:line 130 [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0715440Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: at Microsoft.Testing.Platform.MSBuild.InvokeTestingPlatformTask.GenerateFullPathToTool() in /_/src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs:line 130 [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0793294Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Testing.Platform.MSBuild.InvokeTestingPlatformTask.GenerateFullPathToTool() in /_/src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs:line 130 [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0813840Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: at Microsoft.Build.Utilities.ToolTask.ComputePathToTool() [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.0840433Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Build.Utilities.ToolTask.ComputePathToTool() [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.0933834Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: at Microsoft.Build.Utilities.ToolTask.Execute() [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1038775Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) at Microsoft.Build.Utilities.ToolTask.Execute() [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1051025Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1057721Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1073737Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: WRN: Assembly binding logging is turned OFF. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1079125Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) WRN: Assembly binding logging is turned OFF. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1119976Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1272086Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1305788Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: Note: There is some performance penalty associated with assembly bind failure logging. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1445161Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) Note: There is some performance penalty associated with assembly bind failure logging. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1516972Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1565933Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog]. [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1601280Z D:\a\_work\1\s\.packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj] [D:\a\_work\1\s\test\IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests\Microsoft.Testing.Platform.Acceptance.IntegrationTests.csproj]
2025-01-31T12:10:37.1639377Z ##[error].packages\microsoft.testing.platform.msbuild\1.6.0-ci\buildMultiTargeting\Microsoft.Testing.Platform.MSBuild.targets(322,5): error MSB6003: (NETCORE_ENGINEERING_TELEMETRY=Build) [D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj]
2025-01-31T12:10:37.1747431Z     Done Building Project "D:\a\_work\1\s\artifacts\tmp\Debug\testsuite\d2xJk\MSBuildTests\MSBuild Tests.csproj" (Build;Test target(s)) -- FAILED.
2025-01-31T12:10:37.1821410Z     Build FAILED.

For some reason, I cannot repro this locally.

I found this very old issue which looks somewhat related dotnet/sdk#8124. The integration test is running MSBuild.exe on some project, and we have a custom ToolTask that will attempt to run dotnet.exe. Is there something obvious for you? @rainersigwald

rainersigwald · 2025-02-03T22:30:36Z

Any hope of getting a binlog? I wonder if something is setting DOTNET_HOST_PATH or something?

Youssef1313 · 2025-02-04T07:22:12Z

msbuild.zip

Nope, DOTNET_HOST_PATH doesn't seem to be set

Youssef1313 · 2025-02-04T07:38:07Z

@rainersigwald Note: Microsoft.Testing.Platform.MSBuild project has a dependency on Microsoft.Win32.Registry NuGet package because we try to read registry key when resolving for dotnet.exe on Windows. I assume our packaging here for the MSBuild task is incorrect and we should ship dlls of dependencies (such as Microsoft.Win32.Registry) in _MSBuildTasks folder of the package (this is the folder that we use the task from in UsingTask)

Youssef1313 · 2025-02-04T11:36:15Z

src/Platform/Microsoft.Testing.Platform.MSBuild/Microsoft.Testing.Platform.MSBuild.csproj

@@ -47,6 +47,7 @@ This package provides MSBuild integration of the platform, its extensions and co
    <ItemGroup>
      <TfmSpecificPackageFile Include="@(ReferenceCopyLocalPaths->WithMetadataValue('ReferenceSourceTarget', 'ProjectReference')->WithMetadataValue('PrivateAssets', 'All'))" PackagePath="lib\$(TargetFramework)\%(ReferenceCopyLocalPaths.DestinationSubDirectory)" />
      <BuildOutputInPackage Include="@(ReferenceCopyLocalPaths->WithMetadataValue('ReferenceSourceTarget', 'ProjectReference')->WithMetadataValue('CopyToBuildOutput', 'true'))" TargetPath="%(ReferenceCopyLocalPaths.DestinationSubDirectory)" />
+      <BuildOutputInPackage Include="@(RuntimeTargetsCopyLocalItems->HasMetadata('NuGetPackageId'))" TargetPath="%(RuntimeCopyLocalPaths.DestinationSubPath)" />


Hopefully this gets us green.

It adds three extra dlls to the package:

@rainersigwald Is this the right way to package?

Youssef1313 added 2 commits January 30, 2025 13:29

Fix InvokeTestingPlatformTask to handle running with msbuild.exe and …

c813c0e

…'Test' target

Add test

efcac26

Youssef1313 force-pushed the msbuild-fix branch from 90d65ae to efcac26 Compare January 31, 2025 09:30

Youssef1313 marked this pull request as ready for review January 31, 2025 09:38

Youssef1313 requested review from MarcoRossignoli and Evangelink as code owners January 31, 2025 09:38

Evangelink previously approved these changes Jan 31, 2025

View reviewed changes

microsoft-github-policy-service bot added the Area: Testing Platform MSBuild label Jan 31, 2025

Test is Windows only

9e7bd72

Youssef1313 dismissed Evangelink’s stale review via 9e7bd72 January 31, 2025 10:29

Youssef1313 added 2 commits February 4, 2025 05:14

Binlog

efaa271

Binlog

2f97da1

Fix packaging and refactor task

0a3c462

Youssef1313 commented Feb 4, 2025

View reviewed changes

Evangelink previously approved these changes Feb 4, 2025

View reviewed changes

Evangelink enabled auto-merge (squash) February 4, 2025 11:36

Fix test failure

6500e0b

Youssef1313 dismissed Evangelink’s stale review via 6500e0b February 4, 2025 12:12

Youssef1313 added 3 commits February 4, 2025 15:47

Adjust

44a3a08

Try resolve from PATH first

ebd77a2

Remove unused using

9261da3

Evangelink approved these changes Feb 4, 2025

View reviewed changes

Evangelink merged commit e6974d5 into microsoft:main Feb 4, 2025
8 checks passed

Youssef1313 deleted the msbuild-fix branch February 4, 2025 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix InvokeTestingPlatformTask to handle running with msbuild.exe and 'Test' target #4840

Fix InvokeTestingPlatformTask to handle running with msbuild.exe and 'Test' target #4840

Youssef1313 commented Jan 30, 2025 •

edited

Loading

Evangelink commented Jan 31, 2025

Youssef1313 commented Jan 31, 2025

rainersigwald commented Feb 3, 2025

Youssef1313 commented Feb 4, 2025

Youssef1313 commented Feb 4, 2025

Youssef1313 Feb 4, 2025

Fix InvokeTestingPlatformTask to handle running with msbuild.exe and 'Test' target #4840

Fix InvokeTestingPlatformTask to handle running with msbuild.exe and 'Test' target #4840

Conversation

Youssef1313 commented Jan 30, 2025 • edited Loading

Evangelink commented Jan 31, 2025

Youssef1313 commented Jan 31, 2025

rainersigwald commented Feb 3, 2025

Youssef1313 commented Feb 4, 2025

Youssef1313 commented Feb 4, 2025

Youssef1313 Feb 4, 2025

Choose a reason for hiding this comment

Youssef1313 commented Jan 30, 2025 •

edited

Loading