Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discovery and Get API root Information endpoints #20

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

seansica
Copy link
Contributor

TAXII API Endpoints Fixes and Improvements

This PR addresses several issues in our TAXII API endpoints, improving compliance with the TAXII 2.1 specification and enhancing overall consistency.

Changes

  1. Discovery Endpoint: Fixed the API root path issue.

    • Added a leading '/' to the relative path returned by the discovery endpoint.
  2. Get API Root Information Endpoint: Corrected the version property.

    • Changed version: string to versions: string[] to correctly represent multiple supported versions.
  3. Property Naming Convention: Implemented consistent snake_case for all properties.

    • Updated the following properties to use snake_case:
      • maxContentLengthmax_content_length
      • canReadcan_read
      • canWritecan_write

These changes improve our API's adherence to the TAXII 2.1 specification and provide a more consistent interface for our users.

Testing

  • Verified that the discovery endpoint now returns the correct API root path with a leading '/'.
  • Confirmed that the Get API Root Information endpoint returns versions as an array of strings.
  • Tested all affected endpoints to ensure proper snake_case naming for all properties.

@seansica seansica self-assigned this Sep 12, 2024
@seansica seansica merged commit f8d4a9f into main Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant