Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLORES 200 test set #288

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

mkuchnik
Copy link
Contributor

@mkuchnik mkuchnik commented Nov 2, 2023

FLORES 200 dataset contained training set only. Now it has the test set.

@mkuchnik mkuchnik requested a review from a team as a code owner November 2, 2023 17:35
Copy link

github-actions bot commented Nov 2, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks1

@@ -215,6 +231,152 @@
}
}
]
},
{
"@type": "ml:RecordSet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: An alternate approach would have been to specify "split": "dev" | "devtest" as a parameter of all ml:RecordSets in order not to repeat them.

But because filtering is not implemented yet in mlcroissant, your current approach is probably the best.

@mkuchnik mkuchnik merged commit 5c4b075 into mlcommons:main Nov 3, 2023
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants