Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EOF newline to introduction notebook #289

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add EOF newline to introduction notebook #289

merged 1 commit into from
Nov 3, 2023

Conversation

mkuchnik
Copy link
Contributor

@mkuchnik mkuchnik commented Nov 2, 2023

JSON dump doesn't seem to add newline at end of file. Adding newline to prevent confusion when programmatically creating datasets.

@mkuchnik mkuchnik requested a review from a team as a code owner November 2, 2023 23:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

marcenacp
marcenacp approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@marcenacp marcenacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkuchnik mkuchnik merged commit 3f1fc3b into mlcommons:main Nov 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcenacp marcenacp marcenacp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkuchnik @marcenacp