Add bahnpark v2.3 converter #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: there is no occupancies endpoint anymore with v2, and db bahnpark imposes heavy rate limits, so the usability of this scraper is fairly limited without increased limits
...and don't call get_lot_data for realtime
derhuerst
reviewed
Nov 13, 2023
| - or in a `.env` file in the root of the scraper package containing: `BAHN_API_TOKEN=xxx` | ||
| This scraper is disabled unless you define your DB credentials, either in | ||
| - environment: e.g. `export DB_CLIENT_ID=xxx && export DB_API_KEY=yyy` before running the scraper | ||
| - or in a `.env` file in the root of the scraper package containing: `DB_CLIENT_ID=xxx DB_API_KEY=yyy` |
There was a problem hiding this comment.
Does this work? Or does it have to be two separate lines DB_CLIENT_ID=xxx & DB_API_KEY=yyy?
| warnings.warn( | ||
| "Deutsche Bahn Parking API disabled! " | ||
| "You need to define BAHN_API_TOKEN in environment or in a .env file" | ||
| "You need to define DB_CLIENT_ID and DB_API_KEY in environment or in a .env file" | ||
| ) | ||
|
|
||
| else: |
There was a problem hiding this comment.
This script cannot function without $DB_CLIENT_ID & $DB_API_KEY, right?
If that is the case, I recommend aborting (exiting the process) with a non-0 status code, so that the calling script/user can react accordingly. Also, from the warnings.warn() docs (emphasis mine):
Warning messages are typically issued in situations where it is useful to alert the user of some condition in a program, where that condition (normally) doesn’t warrant raising an exception and terminating the program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a converter for DB Bahnpark API 2.3.x.
Note that it requires #1 to be merged.
Note also, that the rate limits imposed bei the Bahnpark imply that this converter can not be used with DB Bahnpark's usual test access.