RUST-2027 Impl Hash/Eq for BSON #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added feature `hashable` (and to README.md). * `Bson::Double` - implemented the same solution as [`serde_json`](https://docs.rs/serde_json/1.0.127/src/serde_json/number.rs.html#53-70). * `Bson::Document(Document)` - implemented the same solution as [`serde_json`](https://docs.rs/serde_json/1.0.127/src/serde_json/map.rs.html#395-397). * `Bson::JavaScriptCodeWithScope(JavaScriptCodeWithScope)` - Able to impl Hash/Eq only if Document is impl Hash/Eq. * `Bson::{RegularExpression(Regex), Binary(Binary), Decimal128(Decimal128), DbPointer(DbPointer)}` - Added Derive Hash/Eq without feature flag `hashable`, no reason for it not to implement those by default.
abr-egn
approved these changes
Sep 3, 2024
|
Thank you for the well-thought-out PR! The changes look good to me and I've started a test run; once the tests pass and this is reviewed by another team member we'll merge it in. |
|
On the topic of switching |
isabelatkinson
requested changes
Sep 4, 2024
Co-authored-by: Isabel Atkinson <[email protected]>
Co-authored-by: Isabel Atkinson <[email protected]>
isabelatkinson
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#494
Summery of changes:
hashableto require the user to choose to opt-in usingBsonas hash key.Although,
serde_jsondidn't bother with having this behind the feature flag, so If you like I can remove it.Bson::Double(f64)- implemented the same solution asserde_json.Bson::Document(Document)- implemented the same solution asserde_json.Bson::JavaScriptCodeWithScope(JavaScriptCodeWithScope)- Able to impl Hash/Eq only if Document is impl Hash/Eq.Bson::{RegularExpression(Regex), Binary(Binary), Decimal128(Decimal128), DbPointer(DbPointer)}- Added Derive Hash/Eq without feature flaghashable, no reason for it not to implement those by default.I didn't implement it yet, but if the above feature is acceptable,
it might be worth adding another feature like
not(preserve_order)fromserde_json,to change
Bson::Documentto useBTreeMapinstead ofindexmapfor more efficient hashing (likeserde_json).I don't mind adding this as a separate PR.