Update fork of antefoyer that is used, replace setup.py with pyproject.toml
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
CalCraven
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
This looks good to me. I was also thinking, since antefoyer is not necessarily maintained, we could just make a mosdef version of the GAFF.xml file, since upon inspection that is the only place where antefoyer is used in this package. Would reduce the dependencies list. This is probably a good enough fix for now though.
|
The odd part is none of the automated tests are running on this PR though... |
It looks like the workflows on this repo were disabled due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44. I forked Ryan DeFever's antefoyer and removed some CI/versionining stuff that he copied over from Computational Molecular Science Python Cookiecutter, which was causing errors when running
pip install. We could also make a mosdef fork of antefoyer and used that instead if we think that's a better route in case any more maintenance issues come up.This also replaces
setup.pywithpyproject.tomllike I've started in mBuild and GMSO. This should fix failing bleeding edge test in GMSO.