Add temporary fix for periodic dihedrals #327
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Addressing issues raised in #323 and #326. Two changes in
forcefield.py
:verbose=True
, compare the openmm dihedrals to both parmed rb_torsions and dihedrals. This allows a system with periodic dihedrals to be compared withstructure.dihedrals
.This is very much a temporary fix, and I expect dihedrals will be handled much better with the new backend. This is also just an idea, so feel free to tell me if it's a bad one.
PR Checklist