Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile banner #2

Closed
wants to merge 1 commit into from
Closed

profile banner #2

wants to merge 1 commit into from

Conversation

PandaIN95
Copy link

shows a view profile banner button if the user has a banner

shows a view profile banner button if the user has a banner
@thomasbnt thomasbnt self-requested a review August 8, 2022 11:55
@thomasbnt thomasbnt added the Enhancement New feature or request label Aug 8, 2022
@thomasbnt thomasbnt modified the milestone: v1.1.0 Aug 8, 2022
@thomasbnt
Copy link
Member

For the location, a button to view the image is not the best solution.

It would be better to display it, which would change the design of the whole page.
Rather on the v2, or if we manage to integrate it well without that it disturbs, why not for the v1.1.0

@thomasbnt
Copy link
Member

This PR is closed, but this idea to add banner on Whois is appreciated and maybe adding to the v2.

See #3

@thomasbnt thomasbnt closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants