Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multihash): update MSRV to 1.60.0 and use new syntax for cargo features #258

Closed
wants to merge 3 commits into from
Closed

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Dec 13, 2022

and some trivial things:

  • use sha1 instead of sha-1 dependency
  • update strobe-rs v0.7.0 ==> v0.8.1
  • update serde-big-array v0.3.2 ==> v0.4.1
  • update multihash-derive to edition 2021
  • move the resolver = "2" to workspace

…eatures

some trivials:

- use sha1 instead of sha-1 dependency
- update strobe-rs v0.7.0 ==> v0.8.1
- update serde-big-array v0.3.2 ==> v0.4.1
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the resolver = 2 needed in the workspace?

Moving to a new edition is usually a breaking change, hence it wasn't done for the derive crate yet, as I didn't want to do a breaking change release, just for upgrading the edition.

Also bumping the MSRV usually is a breaking change. I'd like to keep doing breaking releases to a minimum. Is there a way doing the crate updates without bumping the MSRV (or was bumping it the whole point?)?

@koushiro
Copy link
Contributor Author

Is the resolver = 2 needed in the workspace?

The resolver is a global setting for a workspace, and the setting is ignored in dependencies. The setting is only honored for the top-level package of the workspace.

see https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#details for details.

Moving to a new edition is usually a breaking change, hence it wasn't done for the derive crate yet, as I didn't want to do a breaking change release, just for upgrading the edition.

Also bumping the MSRV usually is a breaking change. I'd like to keep doing breaking releases to a minimum.

I know the upgrading the edition and MSRV are breaking changes, so you can merge this PR next time you need to upgrade the minor version.

@thomaseizinger
Copy link
Contributor

I think most of this happened in #272 now.

@koushiro koushiro closed this Apr 14, 2023
@koushiro koushiro deleted the some-improvements branch April 14, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants