FIX(client): Infinite loop and log spam on ALSA input device disconnection #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
approved these changes
Jan 14, 2025
Hartmnt
approved these changes
Jan 14, 2025
davidebeatrici
force-pushed
the
alsa-handle-enodev
branch
from
d478a09 to
14bb94e
Compare
…ction A user reported that sometimes the client log gets spammed with repeated messages such as: <W>2025-01-10 10:24:10.638 ALSAAudioInput: No such device: No such device The error corresponds to ENODEV (19), which we treat like any other. Since it's unrecoverable, the code gets stuck in a full speed loop until the audio engine is stopped. This commit: 1. Switches from snd_pcm_prepare() to snd_pcm_recover(), which is specifically designed to recover streams. 2. Breaks the loop if the error is not one of the only three recoverable (EINTR, EPIPE, ESTRPIPE). Example log: <W>2025-01-14 06:16:44.494 ALSAAudioInput encountered unrecoverable error: File descriptor in bad state -> exiting... Please note that also ALSAAudioOutput doesn't explicitly handle fatal errors in its loop, but it shouldn't run "infinitely" at full speed because poll-based.
davidebeatrici
force-pushed
the
alsa-handle-enodev
branch
from
14bb94e to
d2dfcd3
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Krzmbrzl
added a commit
that referenced
this pull request
Jan 16, 2025
…and log spam on ALSA input device disconnection"
|
Just wanted to say thank you for this - I've been using a local patch to do something similar for a while, since the log spam would fill up my disk space and wasn't easily recoverable since the log file in question was kept open by X11, so in the end I just commented out the errors. It looks like I may not to do this any more - thank you! |
|
You're welcome! I kindly ask you to submit a report if you encounter any issues in the future though, as we were unaware of this one until last week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that sometimes the client log gets spammed with repeated messages such as:
<W>2025-01-10 10:24:10.638 ALSAAudioInput: No such device: No such deviceThe error corresponds to
ENODEV(19), which we treat like any other.Since it's unrecoverable, the code gets stuck in a full speed loop until the audio engine is stopped.
This commit:
snd_pcm_prepare()tosnd_pcm_recover(), which is specifically designed to recover streams.EINTR,EPIPE,ESTRPIPE). Example log:<W>2025-01-14 06:16:44.494 ALSAAudioInput encountered unrecoverable error: File descriptor in bad state -> exiting...Please note that also
ALSAAudioOutputdoesn't explicitly handle fatal errors in its loop, but it shouldn't run "infinitely" at full speed because poll-based.