Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory sanitizer to be on by default #3183

Merged
merged 3 commits into from
Feb 6, 2025
+6 −9
Merged

Fix memory sanitizer to be on by default #3183

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a4b17b
forgot to add the dollar sign branch around the BUILD_TESTING variable
kevin-f-ortega Feb 5, 2025
9b8578d
removing dead code
kevin-f-ortega Feb 5, 2025
44a7099
Fixing build issues
LeStarch Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions cmake/options.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ option(FPRIME_CHECK_FRAMEWORK_VERSION "(Internal) Check framework version when b
#
# e.g. `-DENABLE_SANITIZER_ADDRESS=OFF`
####
option(ENABLE_SANITIZER_ADDRESS "Enable address sanitizer" BUILD_TESTING)
option(ENABLE_SANITIZER_ADDRESS "Enable address sanitizer" ${BUILD_TESTING})

####
# `ENABLE_SANITIZER_LEAK:`
Expand All @@ -223,7 +223,7 @@ option(ENABLE_SANITIZER_ADDRESS "Enable address sanitizer" BUILD_TESTING)
#
# e.g. `-DENABLE_SANITIZER_LEAK=OFF`
####
option(ENABLE_SANITIZER_LEAK "Enable leak sanitizer" BUILD_TESTING)
option(ENABLE_SANITIZER_LEAK "Enable leak sanitizer" ${BUILD_TESTING})

####
# `ENABLE_SANITIZER_UNDEFINED_BEHAVIOR:`
Expand All @@ -240,7 +240,7 @@ option(ENABLE_SANITIZER_LEAK "Enable leak sanitizer" BUILD_TESTING)
#
# e.g. `-DENABLE_SANITIZER_UNDEFINED_BEHAVIOR=ON`
####
option(ENABLE_SANITIZER_UNDEFINED_BEHAVIOR "Enable undefined behavior sanitizer" BUILD_TESTING)
option(ENABLE_SANITIZER_UNDEFINED_BEHAVIOR "Enable undefined behavior sanitizer" ${BUILD_TESTING})

####
# `ENABLE_SANITIZER_THREAD:`
Expand All @@ -259,12 +259,9 @@ option(ENABLE_SANITIZER_UNDEFINED_BEHAVIOR "Enable undefined behavior sanitizer"
####
option(ENABLE_SANITIZER_THREAD "Enable thread sanitizer" OFF)

# Backwards compatibility, when build type=TESTING BUILD_TESTING is on
string(TOUPPER "${CMAKE_BUILD_TYPE}" FPRIME_BUILD_TYPE)
if (FPRIME_BUILD_TYPE STREQUAL "TESTING")
else()
option(BUILD_TESTING OFF)
endif()
# CTest inclusion will default BUILD_TESTING to ON but F Prime uses a default of OFF instead
# Must come before include(CTest)
option(BUILD_TESTING "Enable unit testing in the build" OFF)
include(CTest)

####
Expand Down
Loading