Improve BufferManager assertion context args #3223
Open
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, in some cases, no information or context was provided when this assertion tripped, which made it harder to identify the cause. Include more information in several cases.
thomas-bc
reviewed
Feb 13, 2025
| memorySize == allocatedSize, | ||
| FW_ASSERT(memory != nullptr && memorySize == allocatedSize, | ||
| mgrId, memId, | ||
| static_cast<FwAssertArgType>(reinterpret_cast<FwSizeType>(memory)), |
There was a problem hiding this comment.
Why use reinterpret_cast<FwSizeType> on memory here? Are you looking to print the memory address? We have PlatformPointerCastType to represent pointers as integers
There was a problem hiding this comment.
I somehow didn't realize that type existed! Yes, that's definitely what I want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Previously, in some cases, no information or context was provided when certain assertions tripped. Include more information in several cases.
Rationale
Lack of information in an assertion makes it harder to identify the cause.
Testing/Review Recommendations
N/A
Future Work
N/A