fix: get is_focused value dynamically
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
first execution is on this branch. second execution is on master version @nashaofu @louis030195 Xcap.Zsh.Feb.12.2025.mp4 |
ologbonowiwi
commented
Feb 12, 2025
ologbonowiwi
commented
Feb 12, 2025
| @@ -76,7 +76,7 @@ impl Window { | |||
| } | |||
| /// The window is focused. | |||
| pub fn is_focused(&self) -> bool { | |||
| self.impl_window.is_focused | |||
| self.impl_window.is_focused() | |||
There was a problem hiding this comment.
If we don't get the value from a function, we get the focused app when the Window has been built. now we get if the value is focused at the time of checking instead of a static value
ologbonowiwi
changed the title
is_focused value dynamically
|
nice |
nashaofu
approved these changes
Feb 14, 2025
nashaofu
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #190
activeApplicationto get focused app