Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #31: Single quotes in the expanded args should be escaped #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stmlange
Copy link

Fixes #31

@stmlange stmlange force-pushed the bug_31/add_quoting_to_expanded_args branch from b15cc59 to 87249f0 Compare September 10, 2019 14:14
@natefoo
Copy link
Owner

natefoo commented Jan 23, 2020

Thanks @stmlange. I think you should be able to use the existing fsd_replace function for this.

stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Feb 27, 2020
@stmlange
Copy link
Author

Hi,
sorry for the late reply. I have incorporated your suggestion and will some additional testing....I will follow up once completed.

stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Feb 27, 2020
stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Feb 27, 2020
@stmlange stmlange force-pushed the bug_31/add_quoting_to_expanded_args branch from c11102d to e9b4e01 Compare February 27, 2020 15:33
stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Feb 27, 2020
@stmlange
Copy link
Author

Sorry for the clutter here, but I noticed that when using the existing fsd_replace function I don't need to call fsd_free -- otherwise this results in a double-free. The update I pushed caused all the linkage here :/

@stmlange
Copy link
Author

Mhh after some extensive testing it seems that the fsd_replace-function causes an infinity loop.

stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Mar 12, 2020
stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Sep 8, 2022
stmlange added a commit to stmlange/slurm-drmaa that referenced this pull request Sep 8, 2022
@stmlange
Copy link
Author

stmlange commented Sep 18, 2023

Since you seem active again: Is there anything I could do to get this integrated?

I should note that the previous statement still seems to be accurate:
In my custom version using the fsd_replace-function seems to cause an infinity loop.
Hence I'm using the proposed alternative:
stmlange@f896f5c

@stmlange
Copy link
Author

stmlange commented Oct 4, 2023

Is there anything I could do to get this integrated (e.g. run further testing or any other experiments)?

@stmlange
Copy link
Author

@natefoo Is there anything I could do to get this integrated (e.g. run further testing or any other experiments)?

@natefoo
Copy link
Owner

natefoo commented Sep 20, 2024

Sorry, not sure how I missed all these notifications - I will take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single quotes in the expanded args should be escaped
2 participants