Remove unused jsm.go dependency and configureNATSCLI logic.
#699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up the code by removing the unused `jsm.go` module and the `configureNATSCLI` function, which relied on it. The change reduces unnecessary dependencies and simplifies the `LoadParams` logic, improving maintainability. Signed-off-by: Alberto Ricart <[email protected]>
|
The removed code creates issues for nats cli. Any reasons why it was added there? |
ripienaar
reviewed
Jan 9, 2025
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
ugh IDEA - let me do a PR to change all of them.
ripienaar
reviewed
Jan 9, 2025
| @@ -355,33 +354,6 @@ func (p *LoadParams) configureNSCEnv() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *LoadParams) configureNATSCLI() error { | |||
There was a problem hiding this comment.
for background, I want this gone because it's causing some weird dependency issues with new nats auth behaviours - so @wallyqs what was this for and I can add similar functionality to nats auth?
Also we cant call Select here to change peoples selected contexts its just rude and unsafe, so for now just remove the whole lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up the code by removing the unused
jsm.gomodule and theconfigureNATSCLIfunction, which relied on it. The change reduces unnecessary dependencies and simplifies theLoadParamslogic, improving maintainability.