-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate release notes on release updates #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Had a few questions and change requests.
a49f693
to
28e73c0
Compare
28e73c0
to
0a1e176
Compare
0a1e176
to
7cc8991
Compare
Sorry - would you mind rebasing now 😅. I think it's a good idea to add formatting rules to the project, but I wanted to split that out from this change. I checked in the biome rules on |
* main: Attempt ncipollo#1 at fixing workflow file Add initial releases workflow Add biome and initial format rules
Done. Still, the
Yes, you guessed correctly, the (before you say: try doing |
Thanks for triggering the tests! Do you need anything else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉. Thank you for bearing with me through my PR feedback haha. Thanks for this contribution!!
@ncipollo I guess you still need to re-push |
Yeah I need push the next minor tag and then update v1 to point to that. I will get to that this weekend. |
Fixes #474
@ncipollo:
dist/*
is part of the repo, since the build/release should be out of here. Let me know if you what me to removedist/*
from the PR (but I had to have it for testing - yes, it works ;-) ).omitBodyDuringUpdate
somewhere or not and what to do in case someone setsbody
explicitly.yarn release
is not working, since it's depending onncc
(not in deps) andts-node
that is not in--production
.