Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the ability to get a public key for an account #436

Merged
merged 4 commits into from
Jan 20, 2025
Merged

feat: Added the ability to get a public key for an account #436

merged 4 commits into from
Jan 20, 2025

Conversation

FroVolod
Copy link
Collaborator

@FroVolod FroVolod commented Jan 16, 2025 •
edited
Loading

Also resolves #371

Screenshot 2025-01-16 at 21 39 20

@FroVolod
Copy link
Collaborator Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Jan 17, 2025 •
edited
Loading

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@akorchyn 8

Your contribution is much appreciated with a final score of 8!
You have received 121 (80 base + 15 weekly bonus + 20 monthly bonus + 5% lifetime bonus) Sloth points for this contribution

@akorchyn received 25 Sloth Points for reviewing and scoring this pull request.

Congratulations @FroVolod! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

akorchyn
akorchyn reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. A few comments left to think a bit.

src/commands/account/get_public_key/mod.rs Show resolved Hide resolved
src/commands/account/get_public_key/from_seed_phrase/mod.rs Outdated Show resolved Hide resolved
src/commands/account/get_public_key/from_legacy_keychain/mod.rs Show resolved Hide resolved
src/commands/account/get_public_key/from_keychain/mod.rs Show resolved Hide resolved
@FroVolod FroVolod marked this pull request as draft January 17, 2025 14:45
@FroVolod FroVolod marked this pull request as ready for review January 17, 2025 19:04
@akorchyn akorchyn merged commit c9758d7 into main Jan 20, 2025
11 checks passed
@akorchyn akorchyn deleted the get-public-key branch January 20, 2025 12:44
@race-of-sloths
Copy link

🥁 Score it!

@akorchyn, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

@akorchyn
Copy link
Collaborator

@race-of-sloths score 8

@frol frol mentioned this pull request Jan 20, 2025
Merged
akorchyn pushed a commit that referenced this pull request Jan 20, 2025
@frol
chore: release v0.18.0 (#432)
4287b2e 
## 🤖 New release
* `near-cli-rs`: 0.17.0 -> 0.18.0 (⚠️ API breaking changes)

### ⚠️ `near-cli-rs` breaking changes

```
--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
  variant AccountActionsDiscriminants::AddKey 7 -> 8 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:68
  variant AccountActionsDiscriminants::DeleteKeys 8 -> 9 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:73
  variant AccountActionsDiscriminants::ManageStorageDeposit 9 -> 10 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:78
  variant AccountActionsDiscriminants::AddKey 7 -> 8 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:68
  variant AccountActionsDiscriminants::DeleteKeys 8 -> 9 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:73
  variant AccountActionsDiscriminants::ManageStorageDeposit 9 -> 10 in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:78

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/enum_variant_added.ron

Failed in:
  variant AccountActionsDiscriminants:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:63
  variant AccountActionsDiscriminants:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:63
  variant CliAccountActions:GetPublicKey in /tmp/.tmpU4QdIS/near-cli-rs/src/commands/account/mod.rs:24
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.18.0](v0.17.0...v0.18.0)
- 2025-01-20

### Added

- Added the ability to get a public key for an account (#436)

### Other

- fixed migration. Added migration saving to be more clear (#434)
- handle new rate-limits for querying pools (#433)
- Extended the documentation for building NEAR CLI from the source code
(#430)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akorchyn akorchyn akorchyn approved these changes

@dj8yfo dj8yfo Awaiting requested review from dj8yfo dj8yfo is a code owner

@PolyProgrammist PolyProgrammist Awaiting requested review from PolyProgrammist PolyProgrammist is a code owner

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: display Ledger key connected to specific HD Path
3 participants
@FroVolod @race-of-sloths @akorchyn