-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance project readme #1293
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
+ Coverage 80.10% 80.18% +0.08%
==========================================
Files 104 104
Lines 14819 14819
==========================================
+ Hits 11871 11883 +12
+ Misses 2948 2936 -12 ☔ View full report in Codecov by Sentry. |
@emarc99 i kind of like it
|
@emarc99 please discard point 4. for now . It had outdated cargo-near and near-cli binaries, not updated to freshes by default. |
I will definitely add the short mention of the pre-installed devcontainer at the end of the video as advised. |
Will do, sir. |
@emarc99 with near/near-devcontainers#2 merged and near/cargo-near-new-project-template#13 pending merge any time now, |
All duly noted, sir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emarc99 is there any version with sound?
We need a short 3-4 minute version with sound/audio commentary uploaded to github, and a link to your loom account to initial longer 30 min version, but with sound, too.
As of now there's 11 min version without sound, as far as i can see hear. Please stop 🛑 sir
-ing everyone around.
Apologies for that. I made the recent update to show some activity. I was busy with the recent ODboost. The video editing might (or will) take some time, so I will open the PR to signal completion. And yes, no audio still. The 11 minutes recent video will be edited (sped up) for the final 3-4 mins cut, plus the audio and effects. Thanks for your patience. Kindly, give me till Wednesday. |
@emarc99 there's really no rush with it. I'll consider the issue locked to you for a month. |
Awesome, thanks! Really appreciate the time. |
Closes: #1219
I just re-did the video recording to better fit my vision for the task and thought to share as update while still editing.
The video recording can be found here.
The runtime might be high but will be reduced to around 3- 4 mins.