chore: making use of keystore_path
#302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
|
Let's make a step back and think how it should be actually implemented: #196 (comment) |
added 2 commits
October 23, 2023 11:56
This reverts commit f70a594.
ghost
marked this pull request as draft
ghost
changed the title
keystore_pathkeystore_path
|
@frol is this PR headed in the right direction? I reasoned testnet and localnet accounts are ok as plain text maybe weigh in on that? |
Repository owner
closed this by deleting the head repository
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thekeystore_pathis unused, there's an issue here indicating the need for a key loader.The keyloader is one of those features that might be rarely used but while reviewing you can nudge me to work on it, I had already started a wip implementation.