-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support config env expansion #2063
Conversation
Signed-off-by: Raffael Sahli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is useful, but another maintainer or the owner need to decide
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2063 +/- ##
==========================================
+ Coverage 61.22% 61.64% +0.42%
==========================================
Files 46 53 +7
Lines 7141 8808 +1667
==========================================
+ Hits 4372 5430 +1058
- Misses 2462 2948 +486
- Partials 307 430 +123 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't see any reason why users would want to keep the original string $XXX
in args. If they do, they can use $$XXX
.
@raffis this pull request has failed checks 🛠 |
Signed-off-by: Raffael Sahli <[email protected]> Co-authored-by: ChristopherHX <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Current situation
Using an .actrc config it is not possible to utilize envs as there is no env expansion since its not invoked from a shell.
I'd like to have a config like this which is currently not working:
Proposal
Expand any envs while appending the caller args.