Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to environment secrets #2653

Merged
merged 5 commits into from
Feb 9, 2025
Merged

chore: move to environment secrets #2653

merged 5 commits into from
Feb 9, 2025

Conversation

cplee
Copy link
Contributor

@cplee cplee commented Feb 9, 2025

  • Remove GORELEASER_GITHUB_TOKEN secret. Instead, use the GITHUB_TOKEN to manage releases by adding permissions to the token
  • Use new GH_ACT_TOKEN secret defined in the release environment. This is a fine grained token with access to the nektos/gh-act repo only

@cplee cplee requested a review from a team as a code owner February 9, 2025 18:59
@cplee cplee requested a review from ChristopherHX February 9, 2025 18:59
Copy link
Contributor

github-actions bot commented Feb 9, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.01s
✅ REPOSITORY gitleaks yes no 2.42s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 10.34s
✅ REPOSITORY secretlint yes no 1.19s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 5.36s
⚠️ YAML prettier 3 1 0.31s
✅ YAML v8r 3 0 2.45s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.58%. Comparing base (5a80a04) to head (12520ce).
Report is 165 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2653      +/-   ##
==========================================
+ Coverage   61.56%   68.58%   +7.02%     
==========================================
  Files          53       72      +19     
  Lines        9002    11046    +2044     
==========================================
+ Hits         5542     7576    +2034     
+ Misses       3020     2900     -120     
- Partials      440      570     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot requested a review from a team February 9, 2025 19:15
@mergify mergify bot added the needs-work Extra attention is needed label Feb 9, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 9, 2025
@mergify mergify bot removed the needs-work Extra attention is needed label Feb 9, 2025
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now, while there is still a little possibility something is going to break on attempt 1

@mergify mergify bot merged commit c2409db into master Feb 9, 2025
12 checks passed
@mergify mergify bot deleted the secrets branch February 9, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants