feat(config): allow to disable api platform support #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2401 +/- ##
==========================================
+ Coverage 90.09% 90.10% +0.01%
==========================================
Files 94 94
Lines 3059 3063 +4
==========================================
+ Hits 2756 2760 +4
Misses 303 303 ☔ View full report in Codecov by Sentry. |
DjordyKoert
reviewed
Jan 18, 2025
| @@ -29,6 +29,10 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->info('If true, `groups` passed to @Model annotations will be used to limit validation constraints') | |||
| ->defaultFalse() | |||
| ->end() | |||
| ->booleanNode('api_platform_support') | |||
There was a problem hiding this comment.
Suggested change
| ->booleanNode('api_platform_support') | |
| ->booleanNode('api_platform') |
| @@ -29,6 +29,10 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->info('If true, `groups` passed to @Model annotations will be used to limit validation constraints') | |||
| ->defaultFalse() | |||
| ->end() | |||
| ->booleanNode('api_platform_support') | |||
| ->info('If false, the service declaration that support ApiPlatform will not be loaded even if ApiPlatform is detected in your installation') | |||
There was a problem hiding this comment.
Suggested change
| ->info('If false, the service declaration that support ApiPlatform will not be loaded even if ApiPlatform is detected in your installation') | |
| ->info('Enable API Platform integration'') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggestion: allow to disable ApiPlatform support. In fact, you may want to document a part of your application (if you have endpoints that are not served by ApiPlatform) by NelmioDocBundle. If this configuration is loaded, the ApiPlatform endpoints are added in all areas of the documentation.
Please let me know what you think of this situation, or if there is any other way to do this.
What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)