Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to wrap a nodes id to the apoc.create.virtual.fromNode #712

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

gem-neo4j
Copy link
Contributor

@gem-neo4j gem-neo4j commented Jan 2, 2025

Apparently the original idea of this function was to just wrap real nodes aka keep their ids, to not break any existing behaviour I have added that as a config option instead

docs: https://github.com/neo4j/docs-apoc/pull/363

@gem-neo4j gem-neo4j force-pushed the dev_add_node_id_wrapping branch from cda32bc to 951ed5a Compare January 3, 2025 08:56
@gem-neo4j gem-neo4j marked this pull request as ready for review January 3, 2025 08:57
@JoelBergstrand JoelBergstrand self-assigned this Jan 7, 2025
Copy link
Contributor

@JoelBergstrand JoelBergstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gem-neo4j gem-neo4j force-pushed the dev_add_node_id_wrapping branch from 951ed5a to 0841984 Compare January 8, 2025 09:47
@gem-neo4j gem-neo4j merged commit 34f83a4 into dev Jan 8, 2025
11 checks passed
@gem-neo4j gem-neo4j deleted the dev_add_node_id_wrapping branch January 8, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants