Skip to content

Commit

Permalink
Increase reconciler timeout after shard split (#10490)
Browse files Browse the repository at this point in the history
Sometimes, especially when the host running the tests is overloaded, we
can run into reconcile timeouts in
`test_timeline_ancestor_detach_idempotent_success`, making the test
flaky. By increasing the timeouts from 30 seconds to 120 seconds, we can
address the flakiness.

Fixes #10464
  • Loading branch information
arpad-m authored Jan 23, 2025
1 parent b6c0f66 commit ca6d72b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test_runner/regress/test_timeline_detach_ancestor.py
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ def test_timeline_ancestor_detach_idempotent_success(

if shards_after > 1:
# FIXME: should this be in the neon_env_builder.init_start?
env.storage_controller.reconcile_until_idle()
env.storage_controller.reconcile_until_idle(timeout_secs=120)
client = env.storage_controller.pageserver_api()
else:
client = env.pageserver.http_client()
Expand Down Expand Up @@ -636,7 +636,7 @@ def test_timeline_ancestor_detach_idempotent_success(
# Do a shard split
# This is a reproducer for https://github.com/neondatabase/neon/issues/9667
env.storage_controller.tenant_shard_split(env.initial_tenant, shards_after)
env.storage_controller.reconcile_until_idle()
env.storage_controller.reconcile_until_idle(timeout_secs=120)

first_reparenting_response = client.detach_ancestor(env.initial_tenant, first_branch)
assert set(first_reparenting_response) == {reparented1, reparented2}
Expand Down

1 comment on commit ca6d72b

@github-actions
Copy link

@github-actions github-actions bot commented on ca6d72b Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7537 tests run: 7142 passed, 0 failed, 395 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 33.5% (8493 of 25342 functions)
  • lines: 49.3% (71377 of 144774 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ca6d72b at 2025-01-23T20:07:31.681Z :recycle:

Please sign in to comment.