Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System test for post-processing agent memory monitoring #178

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

backmari
Copy link
Contributor

Description of the changes

  • advance the post-processing agent version
  • add new system test for post-processing agent memory monitoring
  • move some test helper functions to new module db_utils

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (e98f787) to head (0a99c11).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #178   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari force-pushed the autoreducer_mem_limit_test branch 3 times, most recently from 03706a7 to 79cc602 Compare September 3, 2024 19:19
- add system test for autoreducer memory monitoring
@backmari backmari force-pushed the autoreducer_mem_limit_test branch from 79cc602 to 13603bb Compare September 4, 2024 12:00
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, collecting the database utilities into tests.utils.db_utils is bothering me way more than it should. Can you change it to either be (preferred) tests.utils.db or tests.db_utils? I like that they are collected into a library to make it easier to see the tests apart from getting things in place for them.

Dockerfile.autoreducer Outdated Show resolved Hide resolved
peterfpeterson
peterfpeterson previously approved these changes Sep 6, 2024
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@backmari backmari merged commit 17de271 into next Sep 6, 2024
4 checks passed
@backmari backmari deleted the autoreducer_mem_limit_test branch September 6, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants