-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System test for post-processing agent memory monitoring #178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #178 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 50 50
Lines 4626 4626
=======================================
Hits 3567 3567
Misses 1059 1059 ☔ View full report in Codecov by Sentry. |
03706a7
to
79cc602
Compare
- add system test for autoreducer memory monitoring
79cc602
to
13603bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, collecting the database utilities into tests.utils.db_utils
is bothering me way more than it should. Can you change it to either be (preferred) tests.utils.db
or tests.db_utils
? I like that they are collected into a library to make it easier to see the tests apart from getting things in place for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description of the changes
db_utils
Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer